Simplifies logging to kafka by reducing the message size.

rudolfgrauberger · Oct 19, 2018 · a989cd5 · a989cd5
1 parent 6319447
commit a989cd5
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 12 deletions.
diff --git a/messaging/kafka.js b/messaging/kafka.js
@@ -39,15 +39,18 @@ producer.connect().then((_) => {
    console.log(error);
 });
 
-const createKafkaMessage = (req, res, par) => JSON.stringify({
-   request: req,
-   response: res,
+const createKafkaMessage = (req, par) => JSON.stringify({
+   request: {
+      url: req.url,
+      method: req.method,
+      headers: req.headers
+   },
    params: par
 }, undefined, 3);
 
-const logToKafka = (req, res, par) => {
+const logToKafka = (req, par) => {
    if (connected) {
-      const msg = createKafkaMessage(req, res, par);
+      const msg = createKafkaMessage(req, par);
       producer.send('logging', JSON.stringify({
          service_name: '1_NodeJs_1',
          operation: req.method,

diff --git a/routes/students.js b/routes/students.js
@@ -7,24 +7,23 @@ router.addRoute('/students', (req, res, params) => {
    if (req.method !== 'GET' && req.method !== 'POST') {
       res.statusCode = 405;
       res.end();
-      kafkalogger.logToKafka(req, res, params);
       return;
    }
 
    res.statusCode = 200;
    res.setHeader('Content-Type', 'application/json');
 
    if (req.method === 'GET') {
+      kafkalogger.logToKafka(req, params);
       studentController.getStudents(res);
-      kafkalogger.logToKafka(req, res, params);
    } else if (req.method === 'POST') {
+      kafkalogger.logToKafka(req, params);
       let body = '';
       req.on('data', (chunk) => {
          body += chunk.toString();
       });
       req.on('end', () => {
          studentController.createStudent(req.url, res, JSON.parse(body));
-         kafkalogger.logToKafka(req, res, params);
       });
    }
 });
@@ -33,7 +32,6 @@ router.addRoute('/students/:id', (req, res, params) => {
    if (req.method !== 'GET' && req.method !== 'PATCH' && req.method !== 'DELETE') {
       res.statusCode = 405;
       res.end();
-      kafkalogger.logToKafka(req, res, params);
       return;
    }
 
@@ -42,19 +40,19 @@ router.addRoute('/students/:id', (req, res, params) => {
 
    if (req.method === 'GET') {
       studentController.getStudent(res, params);
-      kafkalogger.logToKafka(req, res, params);
+      kafkalogger.logToKafka(req, params);
    } else if (req.method === 'PATCH') {
+      kafkalogger.logToKafka(req, params);
       let body = '';
       req.on('data', (chunk) => {
          body += chunk.toString();
       });
       req.on('end', () => {
          studentController.updateStudent(res, params, body);
-         kafkalogger.logToKafka(req, res, params);
       });
    } else if (req.method === 'DELETE') {
+      kafkalogger.logToKafka(req, params);
       studentController.deleteStudent(res, params);
-      kafkalogger.logToKafka(req, res, params);
    }
 });