Migrate verb lockfiles into verb's base path #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for colcon_cache to colcon_clean so colcon_clean can clean the cache base path
for specifying a verb's own base path
to simplify provenance, ownership, and cleaning of lockfiles saved to disk, by keeping lockfiles closer to the artifacts they reflect.
Codecov ReportBase: 100.00% // Head: 90.90% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #42 +/- ##
===========================================
- Coverage 100.00% 90.90% -9.10%
===========================================
Files 19 20 +1
Lines 559 605 +46
Branches 97 99 +2
===========================================
- Hits 559 550 -9
- Misses 0 47 +47
- Partials 0 8 +8
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to simplify the provenance, ownership, and cleaning of lockfiles saved to disk. By relocating lockfiles closer to the artifacts they reflect, it should be more straightforward to clean cached lockfiles while cleaning artifacts from a verbs base path.