Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the 'Log in as a user' admin API #19

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

reivilibre
Copy link

@reivilibre reivilibre commented Mar 31, 2023

draft because I haven't tested it yet..

@reivilibre
Copy link
Author

reivilibre commented Mar 31, 2023

I had to backport this to an older version of Ruma so I can't test it.

But so far I have not managed to figure out how to get this request to implement OutgoingRequest...

EDIT: ah, the client cargo feature :-)

@reivilibre reivilibre marked this pull request as ready for review March 31, 2023 15:12
Copy link
Member

@jplatte jplatte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm, I'm not sure why I never reviewed this. Do you mind rebasing? Then I'll merge.


/// Optional: Integer UNIX timestamp in milliseconds for when the access token should expire.
/// If not specified, the returned access token does not expire.
#[serde(default, skip_serializing_if = "Option::is_none")]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

serde(default) is implied for Option<_> typed fields.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants