Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add room details api #30

Merged
merged 1 commit into from
Jan 18, 2025
Merged

feat: Add room details api #30

merged 1 commit into from
Jan 18, 2025

Conversation

kilimnik
Copy link
Contributor

zecakeh
zecakeh reviewed Jan 18, 2025
View reviewed changes
Copy link

@zecakeh zecakeh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am wondering if we should just reuse RoomDetails from the list_rooms endpoint given that this just adds 4 extra fields to it.

src/rooms/room_details/v1.rs Outdated Show resolved Hide resolved
zecakeh
zecakeh reviewed Jan 18, 2025
View reviewed changes
Copy link

@zecakeh zecakeh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you also add a changelog entry?

src/rooms/room_details/v1.rs Outdated Show resolved Hide resolved
src/rooms/room_details/v1.rs Outdated Show resolved Hide resolved
@kilimnik kilimnik force-pushed the room_details branch 3 times, most recently from b0a9eff to 20a65bc Compare January 18, 2025 13:49
zecakeh
zecakeh reviewed Jan 18, 2025
View reviewed changes
CHANGELOG.md Show resolved Hide resolved
@kilimnik kilimnik force-pushed the room_details branch 2 times, most recently from 3d001fc to 2bec9a9 Compare January 18, 2025 15:18
@zecakeh
Copy link

zecakeh commented Jan 18, 2025

You need to rebase this on main to solve conflicts.

@zecakeh zecakeh merged commit 05ce8bd into ruma:main Jan 18, 2025
2 checks passed
@zecakeh
Copy link

zecakeh commented Jan 18, 2025

Thanks again!

@kilimnik kilimnik deleted the room_details branch January 18, 2025 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zecakeh zecakeh zecakeh left review comments

@jplatte jplatte jplatte left review comments

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kilimnik @zecakeh @jplatte