Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added: 2 GitHub app flavors, Changed: 1 app ID #497

Merged
merged 1 commit into from
Jan 18, 2024

Conversation

DarkCrypt
Copy link
Contributor

Added: Foss flavor for Amarok-Hider and Delta-Icons.
Changed: App ID for SoulSearching.

Flavors can only be added if there's a ".suffix" correct? How can we add flavors when they have the same app ID?

Added: Foss flavor for [Amarok-Hider](https://github.com/deltazefiro/Amarok-Hider/blob/main/app/build.gradle) and [Delta-Icons}(https://github.com/Delta-Icons/android/blob/master/app/build.gradle).
Changed: App ID for [SoulSearching](https://github.com/enteraname74/SoulSearching/releases/tag/v0.2.3).

Flavors can only be added if there's a ".suffix" correct? How can we add flavors when they have the same app ID?
@AnonymousWP
Copy link
Contributor

AnonymousWP commented Jan 16, 2024

Honestly starting to wonder what the point is of all these extra apps being added while it seems a new build is not going to be released anytime soon since November.

@DarkCrypt
Copy link
Contributor Author

Are you trying to tell me that the present build of ApkUpdater won't provide updates for these added apps without a new release?

@AnonymousWP
Copy link
Contributor

According to the changelog of releases, it seems like that: https://github.com/rumboalla/apkupdater/releases/tag/3.0.2

GitHub source: Added sdmaid, spotube, trackworktime

@maj113
Copy link

maj113 commented Jan 16, 2024

Well maybe apkupdater could pull a db of apps from this repo instead of being hardcoded inside the app itself

@DarkCrypt
Copy link
Contributor Author

Interesting, I agree with you both. It would also be a good idea to do this for other sources that require manual app additions like GitLab, Codeberg, etc.

I was going to attempt to add flavors since I failed to do so while adding apps in previous PR's. Instead I'll refrain from any future additions until we here word from rumboalla.

@rumboalla
Copy link
Owner

This is a very good idea, I added it to the list.

@rumboalla rumboalla merged commit ff5d955 into rumboalla:3.x Jan 18, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants