Merge pull request #30 from run-as-root/feature/#27-ignore-exceptions

Changes to skip the message retry
run-as-root · May 16, 2023 · 1f2cb77 · 1f2cb77
2 parents e5bf39e + 207fb78
commit 1f2cb77
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/src/Plugin/HandleQueueMessageRejectPlugin.php b/src/Plugin/HandleQueueMessageRejectPlugin.php
@@ -36,7 +36,7 @@ public function aroundReject(
         }
 
         if (str_contains($rejectionMessage, 'MESSAGE_QUEUE_SKIP_RETRY')) {
-            $proceed($envelope, $requeue, $rejectionMessage);
+            $subject->acknowledge($envelope);
             return;
         }
 

diff --git a/src/Test/Unit/Plugin/HandleQueueMessageRejectPluginTest.php b/src/Test/Unit/Plugin/HandleQueueMessageRejectPluginTest.php
@@ -107,7 +107,7 @@ public function testItShouldSkipRetryWhenExceptionMessageContainsAnUniqueIdentif
             $exceptionMessage
         );
 
-        self::assertTrue($this->isProceedCalled);
+        self::assertFalse($this->isProceedCalled);
     }
 
     public function skipRetryDataProvider(): array
-Original file line number
+Diff line change
@@ Expand Up / @@ -36,7 +36,7 @@ public function aroundReject( @@
             }
             if (str_contains($rejectionMessage, 'MESSAGE_QUEUE_SKIP_RETRY')) {
-                $proceed($envelope, $requeue, $rejectionMessage);
+                $subject->acknowledge($envelope);
                 return;
             }
@@ Expand Down @@