Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bugfix: Issue #455: StorageContext not saving data after deleting document/ref info #486

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

bugfix: Issue #455: StorageContext not saving data after deleting document/ref info #486

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
fda0df6
bugfix: save is not working after delete document or refinfo
1997roylee Jan 30, 2024
2b2af4f
delete method in SimpleKVStore to remove persist functionality
1997roylee Jan 31, 2024
6f6bb96
Refactor instanceof check in code to use SimpleKVStore instead of Bas…
1997roylee Jan 31, 2024
d66a242
remove a empty line
1997roylee Jan 31, 2024
907385e
Merge branch 'main' into main
1997roylee Jan 31, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions packages/core/src/storage/kvStore/SimpleKVStore.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,11 @@ export class SimpleKVStore extends BaseKVStore {
): Promise<boolean> {
if (key in this.data[collection]) {
delete this.data[collection][key];

if (this.persistPath) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@1997roylee thanks for looking into #455!
but persisting the whole store can take a long time, so doing it for every change operation seems not to be feasible. That's why we're having the explicit persist method.
We're working on a fix for #455.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It makes sense, but why is the 'persist' method checking if the instance is equal to 'BaseInMemoryKVStore'? I don't see any involvement of 'SimpleDocumentStore' with 'BaseInMemoryKVStore'.

I proposed to change the BaseInMemoryKVStore to SimpleKVStore.

Original code:

this.kvStore instanceof BaseInMemoryKVStore

Now:

this.kvStore instanceof SimpleKVStore

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@1997roylee good catch, i think we don't need this instanceof check at all - @himself65 can you have a look into this while working on #487 ?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes I think instanceof is useless here. But it okay for now

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should I close this PR? Or I can help to fix the persist issue of another class.

await this.persist(this.persistPath, this.fs); // Save the data after deleting the key
}

return true;
}
return false;
Expand Down