Add unit test for queue consumer #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nerdai
commented
Jun 7, 2024
| task = asyncio.create_task(mq.start()) | ||
|
|
||
| # Act | ||
| await consumer_one.start_consuming(message_queue=mq) |
There was a problem hiding this comment.
@logan-markewich thoughts on this?
I kinda feel like its redundant, but I know RabbitMQ has something like this where you define a consumer and you can start consuming from it as well.
I say its redundant cause you can do this from the message queue side using mq.register_consumer() (in fact that's what's being called here under the hood in consumer.start_consuming(mq).
There was a problem hiding this comment.
Hmm yea, I guess is there a use case for having both directions (i.e. register vs explicitly calling start_consuming)?
There was a problem hiding this comment.
Keeping it for now then lol
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.