feat: Add services registration API to Client
#340
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| self.items.pop(service_name) | ||
|
|
||
|
|
||
| class Core(Model): |
There was a problem hiding this comment.
For now, core only has services -- hypothetically, what else do you think would go here in the future? 👀
There was a problem hiding this comment.
Mainly sessions. Basically I'm moving under core all the client capabilities needed to talk to the ControlPlane.
There was a problem hiding this comment.
The hope is we can direct users towards two directions: apiserver (managed deployments) and core (manual deployments) to map the user stories we have in the docs.
logan-markewich
approved these changes
Oct 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #335
client.core.servicesAlso in this PR:
timeoutto the client every single request. It can still be passed if one needs a custom value.conftest.pyto reduce duplicationscope=sessionso every e2e function has a fresh control plane to test