Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Migrate e2e test basic_workflow to new Client and port missing features from old client #342

Merged
merged 4 commits into from
Oct 29, 2024
Merged

feat: Migrate e2e test basic_workflow to new Client and port missing features from old client #342

merged 4 commits into from
Oct 29, 2024

Conversation

masci
Copy link
Member

@masci masci commented Oct 29, 2024 •
edited
Loading

Part of #335

Also in this PR:

  • implement the same strategy of "lazy connections" we introduced for SessionCollection to ServiceCollection. This way we can expose client.core.services as a property and save one await.

@coveralls
Copy link

coveralls commented Oct 29, 2024 •
edited
Loading

Coverage Status

coverage: 67.948% (+0.09%) from 67.861%
when pulling bf5f165 on massi/sessions
into cf80392 on main.

@masci masci merged commit 4d4efd7 into main Oct 29, 2024
10 checks passed
@masci masci deleted the massi/sessions branch October 29, 2024 16:52
masci added a commit that referenced this pull request Oct 31, 2024
@masci
feat: Migrate e2e test basic_workflow to new Client and port missin…
99e7e4c 
…g features from old client (#342)

* migrate e2e tests to Client

* adjust unit tests

* fix test

* more fixes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@logan-markewich logan-markewich logan-markewich approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@masci @coveralls @logan-markewich