Updated the simple fusion to handle duplicate nodes (#11542)

run-llama · Mar 1, 2024 · 0e39c36 · c4pi · Mar 5, 2024 · c4pi
1 parent a88bc07
commit 0e39c36
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 2 deletions.
diff --git a/llama-index-core/llama_index/core/retrievers/fusion_retriever.py b/llama-index-core/llama_index/core/retrievers/fusion_retriever.py
@@ -130,7 +130,11 @@ def _simple_fusion(
         for nodes_with_scores in results.values():
             for node_with_score in nodes_with_scores:
                 text = node_with_score.node.get_content()
-                all_nodes[text] = node_with_score
+                if text in all_nodes:
+                    max_score = max(node_with_score.score, all_nodes[text].score)
+                    all_nodes[text].score = max_score
+                else:
+                    all_nodes[text] = node_with_score
 
         return sorted(all_nodes.values(), key=lambda x: x.score or 0.0, reverse=True)
 

diff --git a/llama-index-legacy/llama_index/legacy/retrievers/fusion_retriever.py b/llama-index-legacy/llama_index/legacy/retrievers/fusion_retriever.py
@@ -127,7 +127,11 @@ def _simple_fusion(
         for nodes_with_scores in results.values():
             for node_with_score in nodes_with_scores:
                 text = node_with_score.node.get_content()
-                all_nodes[text] = node_with_score
+                if text in all_nodes:
+                    score = max(node_with_score.score, all_nodes[text].score)
+                    all_nodes[text].score = score
+                else:
+                    all_nodes[text] = node_with_score
 
         return sorted(all_nodes.values(), key=lambda x: x.score or 0.0, reverse=True)