Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add helpers to handle ChatML instruction prompts #10272

Merged
merged 2 commits into from
Feb 28, 2024

Conversation

vollnhals
Copy link
Contributor

Description

Provide a new module chatml_utils with two helper functions messages_to_prompt and completion_to_prompt so that ChatML style instructions can be easily implemented.

Fixes #8161

Type of Change

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

I am using this in a project of mine with a Mistral LLM.

This change could use some automated tests, but I am not familar with the llama_index repo. Please guide me if you want unit tests.

  • Added new unit/integration tests
  • I stared at the code and made sure it makes sense

Suggested Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added Google Colab support for the newly added notebooks.
  • My changes generate no new warnings. Don't know?
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I ran make format; make lint to appease the lint gods

@dosubot dosubot bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Jan 25, 2024
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Feb 28, 2024
@logan-markewich logan-markewich enabled auto-merge (squash) February 28, 2024 15:58
@logan-markewich logan-markewich merged commit 33dfc47 into run-llama:main Feb 28, 2024
8 checks passed
Dominastorm pushed a commit to uptrain-ai/llama_index that referenced this pull request Feb 28, 2024
anoopshrma pushed a commit to anoopshrma/llama_index that referenced this pull request Mar 2, 2024
Izukimat pushed a commit to Izukimat/llama_index that referenced this pull request Mar 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm This PR has been approved by a maintainer size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request]: ChatML support with LlamaCPP
2 participants