Added Embeddings Option on custom Triplets #10629
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
the
size:L
hatianzhang
reviewed
Feb 13, 2024
storage/default__vector_store.json
Outdated
| @@ -0,0 +1 @@ | |||
| { "embedding_dict": {}, "text_id_to_ref_doc_id": {}, "metadata_dict": {} } | |||
There was a problem hiding this comment.
do we need to commit those json files?
There was a problem hiding this comment.
No, they were created by make format and make lint for some reason, added automatically, so I did not touch them.
There was a problem hiding this comment.
could we remove them
I don't think they are needed
There was a problem hiding this comment.
Done @hatianzhang , please check
dosubot
bot
added
size:M
dosubot
bot
added
size:S
hatianzhang
approved these changes
Feb 14, 2024
|
@abhiram1809 since we just upgrade to 0.10.* |
dosubot
bot
added
size:M
|
Thanks @hatianzhang , I got a bit busy |
Dominastorm
pushed a commit
to uptrain-ai/llama_index
that referenced
this pull request
Feb 28, 2024
Izukimat
pushed a commit
to Izukimat/llama_index
that referenced
this pull request
Mar 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added an option to include embeddings for triplets that are upserted manually in the Knowledge Graph Index increasing their fetch-ability in the System
Type of Change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Suggested Checklist:
make format; make lintto appease the lint gods