Logan/merge next #10676
Merged
Logan/merge next #10676
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Improve token counting
Merge latest main
Update fern client after eval API
s/textnodeparser/textsplitter etc
Merge latest main into next
dosubot
bot
added
the
size:XXL
Disiok
reviewed
Feb 15, 2024
Disiok
reviewed
Feb 15, 2024
...ices/llama-index-indices-managed-llama-cloud/llama_index/indices/managed/llama_cloud/base.py
Outdated
Show resolved
Hide resolved
Disiok
reviewed
Feb 15, 2024
...ons/embeddings/llama-index-embeddings-huggingface/llama_index/embeddings/huggingface/base.py
Outdated
Show resolved
Hide resolved
Disiok
reviewed
Feb 15, 2024
...s/embeddings/llama-index-embeddings-azure-openai/llama_index/embeddings/azure_openai/base.py
Show resolved
Hide resolved
Disiok
reviewed
Feb 15, 2024
Disiok
approved these changes
Feb 15, 2024
Comment on lines
+122
to
+145
| # check if dataset already exists | ||
| cur_dataset = None | ||
| for dataset in existing_datasets: | ||
| if dataset.name == dataset_name: | ||
| if overwrite: | ||
| assert dataset.id is not None | ||
| client.eval.delete_dataset(dataset_id=dataset.id) | ||
| break | ||
| elif not append: | ||
| raise ValueError( | ||
| f"Dataset {dataset_name} already exists in project {project_name}." | ||
| " Set overwrite=True to overwrite or append=True to append." | ||
| ) | ||
| else: | ||
| cur_dataset = dataset | ||
| break | ||
|
|
||
| # either create new dataset or use existing one | ||
| if cur_dataset is None: | ||
| eval_dataset = client.project.create_eval_dataset_for_project( | ||
| project_id=project.id, name=dataset_name | ||
| ) | ||
| else: | ||
| eval_dataset = cur_dataset |
There was a problem hiding this comment.
note to self - we should create a backend upsert endpoint for this
Disiok
reviewed
Feb 15, 2024
.github/workflows/unit_test.yml
Outdated
| @@ -8,6 +8,8 @@ on: | |||
|
|
|||
| env: | |||
| POETRY_VERSION: "1.6.1" | |||
| LLAMA_CLOUD_BASE_URL: ${{ secrets.PLATFORM_BASE_URL }} | |||
There was a problem hiding this comment.
do we need this? assuming we are not running integration tests here, seem extra.
There was a problem hiding this comment.
yea thats stay stuff. We can remove for now
Dominastorm
pushed a commit
to uptrain-ai/llama_index
that referenced
this pull request
Feb 28, 2024
Izukimat
pushed a commit
to Izukimat/llama_index
that referenced
this pull request
Mar 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.