Update base.py #10707
Update base.py #10707
Conversation
bugfix
dosubot
bot
added
the
size:XS
| @@ -239,7 +239,7 @@ async def _create_index_if_not_exists( | |||
| index_name: Name of the AsyncElasticsearch index to create. | |||
| dims_length: Length of the embedding vectors. | |||
| """ | |||
| if self.client.indices.exists(index=index_name): | |||
| if await self.client.indices.exists(index=index_name): | |||
There was a problem hiding this comment.
I'm 90% sure I changed this to fix this issue?
#10548
There was a problem hiding this comment.
adding await will retintroduce the above issue. But maybe I don't understand whats going on here lol
There was a problem hiding this comment.
There is obviously some problem with different versions of the Elastic Python client. After solving issue #10548, the elastic search example in Llamaindex documentation (https://docs.llamaindex.ai/en/stable/examples/vector_stores/ElasticsearchIndexDemo.html) does not work for me anymore. The exists() method returns coroutine and the condition is therefore always true. The index is never created manually, and with the default mapping, dense vector search does not work. Should I update versions of some libraries to get rid of the asynchronous behavior of the exists() method?
There was a problem hiding this comment.
If this is a client issue, we should set the minimum client version appropriately in the pyproject.toml so that the code will work
|
This has been fixed |
the if is not evaluated correctly