Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Corrective RAG LlamaPack #10715

Merged
merged 6 commits into from
Feb 14, 2024
Merged

Add Corrective RAG LlamaPack #10715

merged 6 commits into from
Feb 14, 2024

Conversation

ravi03071991
Copy link
Contributor

@ravi03071991 ravi03071991 commented Feb 14, 2024 •
edited
Loading

Description

PR to add Corrective RAG paper implementation.

Fixes # (issue)

Type of Change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Added new unit/integration tests
  • Added new notebook (that tests end-to-end)
  • I stared at the code and made sure it makes sense

Suggested Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added Google Colab support for the newly added notebooks.
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I ran make format; make lint to appease the lint gods

@review-notebook-app Review Notebook App
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

@dosubot dosubot bot added the size:L This PR changes 100-499 lines, ignoring generated files. label Feb 14, 2024
nerdai
nerdai approved these changes Feb 14, 2024
View reviewed changes
Copy link
Contributor

@nerdai nerdai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM -- just some minor comments

llama-index-packs/llama-index-packs-corrective-rag/pyproject.toml Show resolved Hide resolved
llama-index-packs/llama-index-packs-corrective-rag/requirements.txt Outdated Show resolved Hide resolved
llama-index-packs/llama-index-packs-corrective-rag/examples/example.py Outdated Show resolved Hide resolved
llama-index-packs/llama-index-packs-corrective-rag/llama_index/packs/corrective_rag/base.py Show resolved Hide resolved
llama-index-packs/llama-index-packs-corrective-rag/README.md Outdated Show resolved Hide resolved
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Feb 14, 2024
nerdai
nerdai approved these changes Feb 14, 2024
View reviewed changes
Copy link
Contributor

@nerdai nerdai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@ravi03071991 ravi03071991 merged commit ebbf1a7 into run-llama:main Feb 14, 2024
8 checks passed
Dominastorm pushed a commit to uptrain-ai/llama_index that referenced this pull request Feb 28, 2024
@ravi03071991 @Dominastorm
Add Corrective RAG LlamaPack (run-llama#10715)
cdd9693 
* Add Corrective RAG LlamaPack

* Update with review suggestions

* Remove requirements.txt file

* Update BUILD

* Update examples

* Testing done
Izukimat pushed a commit to Izukimat/llama_index that referenced this pull request Mar 29, 2024
@ravi03071991
Add Corrective RAG LlamaPack (run-llama#10715)
ae5b024 
* Add Corrective RAG LlamaPack

* Update with review suggestions

* Remove requirements.txt file

* Update BUILD

* Update examples

* Testing done
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@logan-markewich logan-markewich logan-markewich left review comments

@nerdai nerdai nerdai approved these changes

Assignees
No one assigned
Labels
lgtm This PR has been approved by a maintainer size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ravi03071991 @logan-markewich @nerdai