Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated MM video example #10722

Merged
merged 7 commits into from
Feb 14, 2024
Merged

Updated MM video example #10722

merged 7 commits into from
Feb 14, 2024

Conversation

raghavdixit99
Copy link
Contributor

@raghavdixit99 raghavdixit99 commented Feb 14, 2024 •
edited
Loading

Description

Bugfix due to refactor , added a few packages @hatianzhang @ravi03071991

Fixes # (issue)

Type of Change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • This change requires a documentation update

How Has This Been Tested?

  • Added new notebook (that tests end-to-end)

Suggested Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added Google Colab support for the newly added notebooks.
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I ran make format; make lint to appease the lint gods

@dosubot dosubot bot added the size:L This PR changes 100-499 lines, ignoring generated files. label Feb 14, 2024
@review-notebook-app Review Notebook App
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

@dosubot dosubot bot added size:XS This PR changes 0-9 lines, ignoring generated files. and removed size:L This PR changes 100-499 lines, ignoring generated files. labels Feb 14, 2024
@raghavdixit99 raghavdixit99 marked this pull request as draft February 14, 2024 19:59
@raghavdixit99 raghavdixit99 marked this pull request as ready for review February 14, 2024 20:38
@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. and removed size:XS This PR changes 0-9 lines, ignoring generated files. labels Feb 14, 2024
@raghavdixit99
Copy link
Contributor Author

raghavdixit99 commented Feb 14, 2024 •
edited
Loading

@hatianzhang submitting a blogpost with a ref link to the example, kindly merge this as soon as possible , thanks

@raghavdixit99 raghavdixit99 marked this pull request as draft February 14, 2024 21:50
@raghavdixit99 raghavdixit99 marked this pull request as ready for review February 14, 2024 21:53
@hatianzhang hatianzhang enabled auto-merge (squash) February 14, 2024 21:54
@raghavdixit99
Copy link
Contributor Author

@hatianzhang the pr didnt auto merge I guess, can you please have a quick look

hatianzhang
hatianzhang approved these changes Feb 14, 2024
View reviewed changes
Copy link
Contributor

@hatianzhang hatianzhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Feb 14, 2024
@hatianzhang hatianzhang merged commit f7b3fee into run-llama:main Feb 14, 2024
8 checks passed
Dominastorm pushed a commit to uptrain-ai/llama_index that referenced this pull request Feb 28, 2024
@raghavdixit99 @Dominastorm
Updated MM video example (run-llama#10722)
97914e0 
* updated example, pkg breakage due to refactor errors fixed

* typos

* nb clean

* output restored

* formatting

* typo
Izukimat pushed a commit to Izukimat/llama_index that referenced this pull request Mar 29, 2024
@raghavdixit99
Updated MM video example (run-llama#10722)
4a7c7ba 
* updated example, pkg breakage due to refactor errors fixed

* typos

* nb clean

* output restored

* formatting

* typo
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hatianzhang hatianzhang hatianzhang approved these changes

Assignees
No one assigned
Labels
lgtm This PR has been approved by a maintainer size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@raghavdixit99 @hatianzhang