Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The llamaindex cli package #10723

Merged
merged 6 commits into from
Feb 15, 2024
Merged

The llamaindex cli package #10723

merged 6 commits into from
Feb 15, 2024

Conversation

nerdai
Copy link
Contributor

@nerdai nerdai commented Feb 14, 2024

Description

Part 1: Ripping out CLI from llama-index-core

  • Creates a new llama-index python extension package llama-index-cli
  • NOTE i): To invoke this cli tool, we have to use llamaindex rather than llamaindex-cli. This is the case cause core currently occupies that and its still not ripped out from core.
  • NOTE ii): Will publish manually once merged into main

For Part 2:

  • Include this in llama-index python package
  • Remove llamaindex-cli from llama-index-core

Fixes # (issue)

Type of Change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)

@dosubot dosubot bot added the size:XXL This PR changes 1000+ lines, ignoring generated files. label Feb 14, 2024
@nerdai nerdai changed the title llamaindex cli package The llamaindex cli package Feb 14, 2024
version = "0.1.0"

[tool.poetry.dependencies]
python = ">=3.8.1,<3.12"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

btw, I've noticed we have <3.12 in all our packages. We might want to consider making this <4.0.0 🤔

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image
Shoot, so in order to get back "python = 3.8.1<4.0" i think we have to update all pyproject.toml and re-build.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It can be done ofc, but it might be a bit more involved then just changing pyproject.toml's :)

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Feb 15, 2024
@nerdai nerdai force-pushed the nerdai/rip-out-cli-from-core branch from d491069 to f970fa6 Compare February 15, 2024 22:55
@nerdai nerdai enabled auto-merge (squash) February 15, 2024 22:59
@nerdai nerdai merged commit 2ddd720 into main Feb 15, 2024
8 checks passed
@nerdai nerdai deleted the nerdai/rip-out-cli-from-core branch February 15, 2024 23:00
Dominastorm pushed a commit to uptrain-ai/llama_index that referenced this pull request Feb 28, 2024
* llamaindex cli package

* BUILD to pass tests

* generate pants BUILD files

* add skip tests

* use llamaindex-cli name

* CHANGELOG
Izukimat pushed a commit to Izukimat/llama_index that referenced this pull request Mar 29, 2024
* llamaindex cli package

* BUILD to pass tests

* generate pants BUILD files

* add skip tests

* use llamaindex-cli name

* CHANGELOG
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm This PR has been approved by a maintainer size:XXL This PR changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants