Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG-FIX] retriever_mode param missing when constructing KGTableRetriever #10725

Merged
merged 2 commits into from
Feb 14, 2024

Conversation

nerdai
Copy link
Contributor

@nerdai nerdai commented Feb 14, 2024

Description

  • retriever_mode made as explicit param in KnowledgeGraphIndex.as_retriever() but was not propagated to KGTableRetriever

Fixes #10708

Type of Change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • I stared at the code and made sure it makes sense

@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Feb 14, 2024
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Feb 14, 2024
@nerdai nerdai enabled auto-merge (squash) February 14, 2024 20:55
@nerdai nerdai merged commit 809dc3b into main Feb 14, 2024
8 checks passed
@nerdai nerdai deleted the nerdai/bug-fix-kgindex-as-retriever branch February 14, 2024 22:43
Dominastorm pushed a commit to uptrain-ai/llama_index that referenced this pull request Feb 28, 2024
…ever (run-llama#10725)

add retriever_mode param when constructing KGTableRetriever
Izukimat pushed a commit to Izukimat/llama_index that referenced this pull request Mar 29, 2024
…ever (run-llama#10725)

add retriever_mode param when constructing KGTableRetriever
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm This PR has been approved by a maintainer size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: KnowledgeGraphIndex.as_retriever ignores 'retriever_mode' parameter
2 participants