Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved deeplake.py init documentation #10727

Closed

Conversation

nvoxland-al
Copy link
Contributor

Description

Updated documentation for DeepLakeVectorStore init method.

Especially the exec_option docs needed improvement, but did a general cleanup while I was looking at it.

Type of Change

Please delete options that are not relevant.

  • Documentation Fix

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • I stared at the code and made sure it makes sense

Suggested Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added Google Colab support for the newly added notebooks.
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I ran make format; make lint to appease the lint gods

@dosubot dosubot bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Feb 14, 2024
@hatianzhang
Copy link
Contributor

@nvoxland could you pull our latest main and change to new file. 0.10 change our code structure a lot and you need to update to new file. lmk if you need any help

@hatianzhang
Copy link
Contributor

make a new pr to address this #10735

@nvoxland-al
Copy link
Contributor Author

Thanks for getting it fixed up and merged, @hatianzhang !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants