Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add __del__ at Vllm for deleting model #10733

Merged
merged 2 commits into from
Feb 14, 2024
Merged

Add __del__ at Vllm for deleting model #10733

merged 2 commits into from
Feb 14, 2024

Conversation

hatianzhang
Copy link
Contributor

@hatianzhang hatianzhang commented Feb 14, 2024

Description

#10524
#10566

Fixes # (issue)

Type of Change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Added new unit/integration tests
  • Added new notebook (that tests end-to-end)
  • I stared at the code and made sure it makes sense

Suggested Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added Google Colab support for the newly added notebooks.
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I ran make format; make lint to appease the lint gods

@dosubot dosubot bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Feb 14, 2024
@hatianzhang hatianzhang merged commit c6b43b2 into main Feb 14, 2024
8 checks passed
@hatianzhang hatianzhang deleted the hz/vllm branch February 14, 2024 22:28
@vkehfdl1
Copy link
Contributor

Thank you!

Dominastorm pushed a commit to uptrain-ai/llama_index that referenced this pull request Feb 28, 2024
* Add __del__ at Vllm for deleting model

* cr
Izukimat pushed a commit to Izukimat/llama_index that referenced this pull request Mar 29, 2024
* Add __del__ at Vllm for deleting model

* cr
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size:S This PR changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants