-
Notifications
You must be signed in to change notification settings - Fork 5.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ADD(Agent): Can now specify how you want you tool to be found #10784
base: main
Are you sure you want to change the base?
Conversation
@@ -195,6 +199,7 @@ def from_tools( | |||
callback_manager: Optional[CallbackManager] = None, | |||
system_prompt: Optional[str] = None, | |||
prefix_messages: Optional[List[ChatMessage]] = None, | |||
get_tool_by: Callable[[List[BaseTool], str], BaseTool] = get_function_by_name, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we add a similar hook to the react agent? And maybe add a notebook example of how this should be used?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have no idea how the React Agent works, And should I add the example to an existing one or create a new example?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LOL that's fair I guess. I could take a stab.
I would add to an existing example maybe... just adding a section showing this specific customization
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could look into it if you want, it just looks a bit more complex
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Description
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Fixes # (issue)
Type of Change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Suggested Checklist:
make format; make lint
to appease the lint gods