Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed local saving to disk #10786

Closed
wants to merge 1 commit into from
Closed

Fixed local saving to disk #10786

wants to merge 1 commit into from

Conversation

aevedis
Copy link

@aevedis aevedis commented Feb 16, 2024

Description

I added some necessary imports, I removed "uri" as this is not a parameter the QdrantClient accepts, and I substituted it with path instead as now, Qdrant only needs the path where you've saved your text and embeddings to enable retrieval at a second stage.

Fixes # (issue)

Type of Change

Code correction in the notebook example of how to use LLamaIndex with Qdrant.

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Added new unit/integration tests
  • Added new notebook (that tests end-to-end)
  • I stared at the code and made sure it makes sense

Suggested Checklist:

  • [X ] I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added Google Colab support for the newly added notebooks.
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I ran make format; make lint to appease the lint gods

@dosubot dosubot bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Feb 16, 2024
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@@ -32,7 +32,7 @@
"metadata": {},
Copy link
Contributor

@hatianzhang hatianzhang Feb 16, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could you keep the output


Reply via ReviewNB

@logan-markewich
Copy link
Collaborator

Yea, keeping the response outputs (and running make lint) would be nice :)

@logan-markewich
Copy link
Collaborator

Going to close this one out for now, its quite outdated at this point

If its still an issue, please raise an updated PR

Sorry for letting this one sit for so long!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants