Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clickhouse package meta fix #10799

Merged
merged 11 commits into from
Feb 16, 2024
Merged

Clickhouse package meta fix #10799

merged 11 commits into from
Feb 16, 2024

Conversation

gingerwizard
Copy link
Contributor

Description

Fix author metadata preventing package installation.

Type of Change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Added new unit/integration tests
  • Added new notebook (that tests end-to-end)
  • I stared at the code and made sure it makes sense

Suggested Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added Google Colab support for the newly added notebooks.
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I ran make format; make lint to appease the lint gods

@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Feb 16, 2024
@gingerwizard gingerwizard changed the title Clickhouse support Clickhouse package meta fix Feb 16, 2024
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Feb 16, 2024
@hatianzhang hatianzhang merged commit 6eab6fb into run-llama:main Feb 16, 2024
8 checks passed
Dominastorm pushed a commit to uptrain-ai/llama_index that referenced this pull request Feb 28, 2024
@gingerwizard @Dominastorm
Clickhouse package meta fix (run-llama#10799)
653dab5 
* new format

* lint fixes

* revert to string

* use tuple for node info

* support for custom filter

* fix link

* update docs

* update author
anoopshrma pushed a commit to anoopshrma/llama_index that referenced this pull request Mar 2, 2024
@gingerwizard @anoopshrma
Clickhouse package meta fix (run-llama#10799)
3c70c0f 
* new format

* lint fixes

* revert to string

* use tuple for node info

* support for custom filter

* fix link

* update docs

* update author
Izukimat pushed a commit to Izukimat/llama_index that referenced this pull request Mar 29, 2024
@gingerwizard
Clickhouse package meta fix (run-llama#10799)
b684d6c 
* new format

* lint fixes

* revert to string

* use tuple for node info

* support for custom filter

* fix link

* update docs

* update author
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hatianzhang hatianzhang hatianzhang approved these changes

Assignees
No one assigned
Labels
lgtm This PR has been approved by a maintainer size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gingerwizard @hatianzhang