Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add Jina Reranking integration #11291

Merged
merged 8 commits into from
Feb 28, 2024

Conversation

JoanFM
Copy link
Contributor

@JoanFM JoanFM commented Feb 22, 2024

Description

This PR aims to add support for Jina AI reranking the same way it does for embeddings.

Type of Change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Added new unit/integration tests
  • Added new notebook (that tests end-to-end)
  • I stared at the code and made sure it makes sense

Suggested Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added Google Colab support for the newly added notebooks.
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I ran make format; make lint to appease the lint gods

@dosubot dosubot bot added the size:L This PR changes 100-499 lines, ignoring generated files. label Feb 22, 2024
@JoanFM JoanFM marked this pull request as draft February 22, 2024 17:23
@JoanFM JoanFM force-pushed the feat-add-jina-reranking branch 2 times, most recently from 8bd37e4 to b89fbe9 Compare February 22, 2024 17:37
@hatianzhang
Copy link
Contributor

pls also add a notebook to showcase how to use it and your results

Signed-off-by: Joan Martinez <[email protected]>
@JoanFM
Copy link
Contributor Author

JoanFM commented Feb 23, 2024

pls also add a notebook to showcase how to use it and your results

where should I put the notebook? and is there an example for me to follow?

@hatianzhang
Copy link
Contributor

@JoanFM you could follow/put here

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@JoanFM JoanFM marked this pull request as ready for review February 27, 2024 13:11
@JoanFM
Copy link
Contributor Author

JoanFM commented Feb 27, 2024

Contributor

done!

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Feb 27, 2024
@JoanFM JoanFM marked this pull request as draft February 27, 2024 16:30
@JoanFM JoanFM marked this pull request as ready for review February 28, 2024 15:13
@dosubot dosubot bot added size:XL This PR changes 500-999 lines, ignoring generated files. and removed size:L This PR changes 100-499 lines, ignoring generated files. labels Feb 28, 2024
@JoanFM JoanFM requested a review from nerdai February 28, 2024 16:03
@hatianzhang hatianzhang merged commit 8623877 into run-llama:main Feb 28, 2024
8 checks passed
@nerdai
Copy link
Contributor

nerdai commented Feb 28, 2024

@JoanFM @hatianzhang: Thanks!

Published to pypi (see here)

Dominastorm pushed a commit to uptrain-ai/llama_index that referenced this pull request Feb 28, 2024
* feat: add jina reranking

Signed-off-by: Joan Martinez <[email protected]>

* feat: add notebook

* fix: fix linting

* fix: change printing of nodes

* fix: change printing of nodes

* fix: fix output from new model

* fix: fix notebook

* cr

---------

Signed-off-by: Joan Martinez <[email protected]>
Co-authored-by: Haotian Zhang <[email protected]>
anoopshrma pushed a commit to anoopshrma/llama_index that referenced this pull request Mar 2, 2024
* feat: add jina reranking

Signed-off-by: Joan Martinez <[email protected]>

* feat: add notebook

* fix: fix linting

* fix: change printing of nodes

* fix: change printing of nodes

* fix: fix output from new model

* fix: fix notebook

* cr

---------

Signed-off-by: Joan Martinez <[email protected]>
Co-authored-by: Haotian Zhang <[email protected]>
Izukimat pushed a commit to Izukimat/llama_index that referenced this pull request Mar 29, 2024
* feat: add jina reranking

Signed-off-by: Joan Martinez <[email protected]>

* feat: add notebook

* fix: fix linting

* fix: change printing of nodes

* fix: change printing of nodes

* fix: fix output from new model

* fix: fix notebook

* cr

---------

Signed-off-by: Joan Martinez <[email protected]>
Co-authored-by: Haotian Zhang <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm This PR has been approved by a maintainer size:XL This PR changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants