[FIX] faulty imports when using PydanticProgramMode.LM_FORMAT_ENFORCER #11355
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
the
size:S
| try: | ||
| from llama_index.program.lmformatenforcer import ( | ||
| LMFormatEnforcerPydanticProgram, | ||
| ) |
There was a problem hiding this comment.
Can we add the # pants: no-infer-dep comment at the end of this import? (Similar to other 3rd party imports in core)
This helps avoid pants detecting this as a dependency when testing, making the venv smaller for core
There was a problem hiding this comment.
sorry just seeing this now. on it!
There was a problem hiding this comment.
that did the trick - all checks have passed now :)
logan-markewich
approved these changes
Feb 27, 2024
logan-markewich
deleted the
nerdai/fix-broken-import-lmformatenforcer
branch
Dominastorm
pushed a commit
to uptrain-ai/llama_index
that referenced
this pull request
Feb 28, 2024
anoopshrma
pushed a commit
to anoopshrma/llama_index
that referenced
this pull request
Mar 2, 2024
Izukimat
pushed a commit
to Izukimat/llama_index
that referenced
this pull request
Mar 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
PydanticProgramMode.LM_FORMAT_ENFORCERneeds integrationllama-index-program-lmformatenforcerbut when trying to lazy import it from core, it tries to load from ... core :)Fixes #11351
Type of Change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration