Add to BaseSQLTableQueryEngine refine synthesis template #11378
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
the
size:M
| @@ -359,10 +368,14 @@ def _query(self, query_bundle: QueryBundle) -> Response: | |||
| partial_synthesis_prompt = self._response_synthesis_prompt.partial_format( | |||
| sql_query=sql_query_str, | |||
| ) | |||
| partial_refine_prompt = self._refine_synthesis_prompt.partial_format( | |||
| sql_query=sql_query_str, | |||
There was a problem hiding this comment.
hmm, the DEFAULT_REFINE_PROMPT does not have a sql_query variable
There was a problem hiding this comment.
You're right, it's been fixed
| @@ -386,10 +396,14 @@ async def _aquery(self, query_bundle: QueryBundle) -> Response: | |||
| partial_synthesis_prompt = self._response_synthesis_prompt.partial_format( | |||
| sql_query=sql_query_str, | |||
| ) | |||
| partial_refine_prompt = self._refine_synthesis_prompt.partial_format( | |||
| sql_query=sql_query_str, | |||
There was a problem hiding this comment.
I still think theres an issue here -- the default refine synthesis prompt still doesn't have this variable. I think we need a V2 version of this prompt, similar to the main default prompt
There was a problem hiding this comment.
My bad, I just corrected
logan-markewich
approved these changes
Mar 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds the ability to choose a template for the prompt that refine the response from a BaseSQLTableQueryEngine.
Type of Change
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Suggested Checklist:
make format; make lintto appease the lint gods