Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix prompt helper init #11379

Merged
merged 5 commits into from
Feb 26, 2024
Merged

fix prompt helper init #11379

merged 5 commits into from
Feb 26, 2024

Conversation

logan-markewich
Copy link
Collaborator

No description provided.

@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Feb 26, 2024
jerryjliu
jerryjliu approved these changes Feb 26, 2024
View reviewed changes
Copy link
Collaborator

@jerryjliu jerryjliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should prompt_helper_from_settings_or_context be removed?

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Feb 26, 2024
@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. and removed size:XS This PR changes 0-9 lines, ignoring generated files. labels Feb 26, 2024
@logan-markewich
Copy link
Collaborator Author

@jerryjliu made a few (maybe slightly dramatic), but needed changes around this in the process of removing that helper function :)

@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. and removed size:L This PR changes 100-499 lines, ignoring generated files. labels Feb 26, 2024
@logan-markewich logan-markewich merged commit 78a4c9e into main Feb 26, 2024
8 checks passed
@logan-markewich logan-markewich deleted the logan/fix_prompt_helper branch February 26, 2024 19:12
Dominastorm pushed a commit to uptrain-ai/llama_index that referenced this pull request Feb 28, 2024
@logan-markewich @Dominastorm
fix prompt helper init (run-llama#11379)
5e59243
anoopshrma pushed a commit to anoopshrma/llama_index that referenced this pull request Mar 2, 2024
@logan-markewich @anoopshrma
fix prompt helper init (run-llama#11379)
b1850fc
Izukimat pushed a commit to Izukimat/llama_index that referenced this pull request Mar 29, 2024
@logan-markewich
fix prompt helper init (run-llama#11379)
ea068ca
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jerryjliu jerryjliu jerryjliu approved these changes

Assignees
No one assigned
Labels
lgtm This PR has been approved by a maintainer size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@logan-markewich @jerryjliu