Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Elastic Search retrieval : Bug Fix for Cases when No Relationships Detected #11385

Conversation

sonal-511
Copy link
Contributor

Description

  1. Relationship assigned empty dictionary when its not present for Elasticsearch
  2. Removed duplicate code

Type of Change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • I stared at the code and made sure it makes sense

Suggested Checklist:

  • I have performed a self-review of my own code
  • My changes generate no new warnings

1. Relationship assigned empty dictionary when its not present
2. Removed duplicate code
@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Feb 26, 2024
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Feb 26, 2024
@logan-markewich logan-markewich enabled auto-merge (squash) February 26, 2024 15:31
@logan-markewich logan-markewich merged commit 3a10235 into run-llama:main Feb 26, 2024
8 checks passed
Dominastorm pushed a commit to uptrain-ai/llama_index that referenced this pull request Feb 28, 2024
anoopshrma pushed a commit to anoopshrma/llama_index that referenced this pull request Mar 2, 2024
Izukimat pushed a commit to Izukimat/llama_index that referenced this pull request Mar 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm This PR has been approved by a maintainer size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants