-
Notifications
You must be signed in to change notification settings - Fork 5.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix api_base undefined bug in Gemini embeddings #11393
Conversation
Added Gemini transportation method configuration support.
Setting qwen default num_outputs and temperature
support configuring api_base, api_key, transport method
reading a file in default encoding(GBK) will cause error characters problem. Added encoding configuration
@@ -18,6 +18,8 @@ class GeminiEmbedding(BaseEmbedding): | |||
Defaults to "models/embedding-001". | |||
|
|||
api_key (Optional[str]): API key to access the model. Defaults to None. | |||
api_base (Optional[str]): API base to access the model. Defaults to Official Base. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pls move the changes to https://github.com/run-llama/llama_index/blob/main/llama-index-integrations/embeddings/llama-index-embeddings-gemini/llama_index/embeddings/gemini/base.py. this file will be deprecated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yea, the proper version does not have this issue actually
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pls move the changes to https://github.com/run-llama/llama_index/blob/main/llama-index-integrations/embeddings/llama-index-embeddings-gemini/llama_index/embeddings/gemini/base.py. this file will be deprecated
copy that. updated.
* Support Gemini "transport" configuration Added Gemini transportation method configuration support. * Sync updates in multi_modal_llms\gemini * Updated Dashscope qwen llm defaults Setting qwen default num_outputs and temperature * cr * support gemini embedding configuration support configuring api_base, api_key, transport method * fix gptrepo data connector encoding issue reading a file in default encoding(GBK) will cause error characters problem. Added encoding configuration * sync latest repo * sync latest repo * cr * cr * Fix api_base undefined bug in Gemini embeddings * add comments * fix linter test * sync fix in integrations/embeddings * fix unit test --------- Co-authored-by: Haotian Zhang <[email protected]>
* Support Gemini "transport" configuration Added Gemini transportation method configuration support. * Sync updates in multi_modal_llms\gemini * Updated Dashscope qwen llm defaults Setting qwen default num_outputs and temperature * cr * support gemini embedding configuration support configuring api_base, api_key, transport method * fix gptrepo data connector encoding issue reading a file in default encoding(GBK) will cause error characters problem. Added encoding configuration * sync latest repo * sync latest repo * cr * cr * Fix api_base undefined bug in Gemini embeddings * add comments * fix linter test * sync fix in integrations/embeddings * fix unit test --------- Co-authored-by: Haotian Zhang <[email protected]>
* Support Gemini "transport" configuration Added Gemini transportation method configuration support. * Sync updates in multi_modal_llms\gemini * Updated Dashscope qwen llm defaults Setting qwen default num_outputs and temperature * cr * support gemini embedding configuration support configuring api_base, api_key, transport method * fix gptrepo data connector encoding issue reading a file in default encoding(GBK) will cause error characters problem. Added encoding configuration * sync latest repo * sync latest repo * cr * cr * Fix api_base undefined bug in Gemini embeddings * add comments * fix linter test * sync fix in integrations/embeddings * fix unit test --------- Co-authored-by: Haotian Zhang <[email protected]>
Description
api_base variable is used in init(), but isn't conveyed in augment
Type of Change
How Has This Been Tested?
Suggested Checklist:
make format; make lint
to appease the lint gods