Fix api_base undefined bug in Gemini embeddings #11393
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added Gemini transportation method configuration support.
Setting qwen default num_outputs and temperature
support configuring api_base, api_key, transport method
reading a file in default encoding(GBK) will cause error characters problem. Added encoding configuration
dosubot
bot
added
the
size:XS
hatianzhang
reviewed
Feb 26, 2024
| @@ -18,6 +18,8 @@ class GeminiEmbedding(BaseEmbedding): | |||
| Defaults to "models/embedding-001". | |||
| api_key (Optional[str]): API key to access the model. Defaults to None. | |||
| api_base (Optional[str]): API base to access the model. Defaults to Official Base. | |||
There was a problem hiding this comment.
pls move the changes to https://github.com/run-llama/llama_index/blob/main/llama-index-integrations/embeddings/llama-index-embeddings-gemini/llama_index/embeddings/gemini/base.py. this file will be deprecated
There was a problem hiding this comment.
Yea, the proper version does not have this issue actually
There was a problem hiding this comment.
pls move the changes to https://github.com/run-llama/llama_index/blob/main/llama-index-integrations/embeddings/llama-index-embeddings-gemini/llama_index/embeddings/gemini/base.py. this file will be deprecated
copy that. updated.
dosubot
bot
added
size:S
hatianzhang
approved these changes
Feb 27, 2024
Dominastorm
pushed a commit
to uptrain-ai/llama_index
that referenced
this pull request
Feb 28, 2024
* Support Gemini "transport" configuration Added Gemini transportation method configuration support. * Sync updates in multi_modal_llms\gemini * Updated Dashscope qwen llm defaults Setting qwen default num_outputs and temperature * cr * support gemini embedding configuration support configuring api_base, api_key, transport method * fix gptrepo data connector encoding issue reading a file in default encoding(GBK) will cause error characters problem. Added encoding configuration * sync latest repo * sync latest repo * cr * cr * Fix api_base undefined bug in Gemini embeddings * add comments * fix linter test * sync fix in integrations/embeddings * fix unit test --------- Co-authored-by: Haotian Zhang <[email protected]>
anoopshrma
pushed a commit
to anoopshrma/llama_index
that referenced
this pull request
Mar 2, 2024
* Support Gemini "transport" configuration Added Gemini transportation method configuration support. * Sync updates in multi_modal_llms\gemini * Updated Dashscope qwen llm defaults Setting qwen default num_outputs and temperature * cr * support gemini embedding configuration support configuring api_base, api_key, transport method * fix gptrepo data connector encoding issue reading a file in default encoding(GBK) will cause error characters problem. Added encoding configuration * sync latest repo * sync latest repo * cr * cr * Fix api_base undefined bug in Gemini embeddings * add comments * fix linter test * sync fix in integrations/embeddings * fix unit test --------- Co-authored-by: Haotian Zhang <[email protected]>
Izukimat
pushed a commit
to Izukimat/llama_index
that referenced
this pull request
Mar 29, 2024
* Support Gemini "transport" configuration Added Gemini transportation method configuration support. * Sync updates in multi_modal_llms\gemini * Updated Dashscope qwen llm defaults Setting qwen default num_outputs and temperature * cr * support gemini embedding configuration support configuring api_base, api_key, transport method * fix gptrepo data connector encoding issue reading a file in default encoding(GBK) will cause error characters problem. Added encoding configuration * sync latest repo * sync latest repo * cr * cr * Fix api_base undefined bug in Gemini embeddings * add comments * fix linter test * sync fix in integrations/embeddings * fix unit test --------- Co-authored-by: Haotian Zhang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
api_base variable is used in init(), but isn't conveyed in augment
Type of Change
How Has This Been Tested?
Suggested Checklist:
make format; make lintto appease the lint gods