Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

llama-index-networks package #11413

Merged
merged 12 commits into from
Feb 27, 2024
Merged

llama-index-networks package #11413

merged 12 commits into from
Feb 27, 2024

Conversation

nerdai
Copy link
Contributor

@nerdai nerdai commented Feb 26, 2024

Description

  • This PR moves the llama-index-networks package into llama-index!

Fixes # (issue)

Type of Change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Added new unit/integration tests
  • Added new notebook (that tests end-to-end)
  • I stared at the code and made sure it makes sense

@dosubot dosubot bot added the size:XL This PR changes 500-999 lines, ignoring generated files. label Feb 26, 2024
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. and removed size:XL This PR changes 500-999 lines, ignoring generated files. labels Feb 26, 2024
Copy link
Collaborator

@logan-markewich logan-markewich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tbh this looks good to me! I try to find a chance to test this tonight as well

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Feb 27, 2024
@dosubot dosubot bot added size:XL This PR changes 500-999 lines, ignoring generated files. and removed size:L This PR changes 100-499 lines, ignoring generated files. labels Feb 27, 2024
@nerdai nerdai merged commit 2e63d5e into main Feb 27, 2024
8 checks passed
@nerdai nerdai deleted the nerdai/llama-index-networks branch February 27, 2024 06:55
Dominastorm pushed a commit to uptrain-ai/llama_index that referenced this pull request Feb 28, 2024
* lint

* pants tailor

* remove unnecessary files/folders

* make api_key an optional field

* make secret field optional as well

* top level imports

* prerelease version bump

* remove misleading env variables

* override gitignore to add data to demo

* add note in demo README that you can use  instead of

* update demo contributor poetry.locks pyproject.toml

* published v0.1.0; updated demo deps
anoopshrma pushed a commit to anoopshrma/llama_index that referenced this pull request Mar 2, 2024
* lint

* pants tailor

* remove unnecessary files/folders

* make api_key an optional field

* make secret field optional as well

* top level imports

* prerelease version bump

* remove misleading env variables

* override gitignore to add data to demo

* add note in demo README that you can use  instead of

* update demo contributor poetry.locks pyproject.toml

* published v0.1.0; updated demo deps
Izukimat pushed a commit to Izukimat/llama_index that referenced this pull request Mar 29, 2024
* lint

* pants tailor

* remove unnecessary files/folders

* make api_key an optional field

* make secret field optional as well

* top level imports

* prerelease version bump

* remove misleading env variables

* override gitignore to add data to demo

* add note in demo README that you can use  instead of

* update demo contributor poetry.locks pyproject.toml

* published v0.1.0; updated demo deps
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm This PR has been approved by a maintainer size:XL This PR changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants