[FIX] elasticsearch vector_store: add await for self.client.indices.exist #11438
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
the
size:XS
nerdai
commented
Feb 27, 2024
| @@ -239,7 +239,7 @@ async def _create_index_if_not_exists( | |||
| index_name: Name of the AsyncElasticsearch index to create. | |||
| dims_length: Length of the embedding vectors. | |||
| """ | |||
| if self.client.indices.exists(index=index_name): | |||
| if await self.client.indices.exists(index=index_name): | |||
There was a problem hiding this comment.
@logan-markewich IIRC I think there was some reason as to why we removed the await? Or maybe I'm wrong and it never was there to begin with.
I do think we need to have this since the client is and async client though.
There was a problem hiding this comment.
for visibility on this issue:
- it appears a lower version of
elasticsearchpython client actually does not yield a Coroutine whenclinet.indices.existswas invoked (see this older issue) -- thereelasticsearchv8.8.0 was used. - this is no longer the case for the most recent version of
elasticsearch(at time of this comment, v8.12.1). - since v8.12.1 is the minimum requirement for this integration (i.e. see pyproject.toml), we should be safe to add back
awaitnow.
logan-markewich
approved these changes
Feb 27, 2024
12 tasks
Dominastorm
pushed a commit
to uptrain-ai/llama_index
that referenced
this pull request
Feb 28, 2024
…xist (run-llama#11438) await self.client.indices.exist
anoopshrma
pushed a commit
to anoopshrma/llama_index
that referenced
this pull request
Mar 2, 2024
…xist (run-llama#11438) await self.client.indices.exist
Izukimat
pushed a commit
to Izukimat/llama_index
that referenced
this pull request
Mar 29, 2024
…xist (run-llama#11438) await self.client.indices.exist
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
AsyncElasticsearchClientwe need to haveawaitonself.client.indices.existotherwise it returns aCoroutineobjectFixes #11417
Type of Change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration