fixed storage context update & service context issue #11475
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
the
size:XS
logan-markewich
approved these changes
Feb 28, 2024
dosubot
bot
added
size:S
|
I fixed the JSON test issues in another PR, but this seems to be breaking the KG index when building a fresh index. Try To see what I mean |
auto-merge was automatically disabled
February 28, 2024 20:16
Head branch was pushed to by a user without write access
|
I realized that issue and fixed it to move the line into if conditions. I can create KG index with fresh building. However, when building a fresh index, it will call "add_index_struct" two times. |
|
@logan-markewich my last commit passed the tests 🥳 #11474 should be resolved now. |
logan-markewich
approved these changes
Mar 1, 2024
anoopshrma
pushed a commit
to anoopshrma/llama_index
that referenced
this pull request
Mar 2, 2024
bdonkey
added a commit
to bdonkey/gpt_index
that referenced
this pull request
Mar 5, 2024
* main: (2881 commits) Feature: Improve batch embedding generation throughput for Cohere in Bedrock (run-llama#11572) tqdm: add tdqm.gather (run-llama#11562) Fix URLs in Prompts documentation (run-llama#11571) Corrected colab links (run-llama#11577) add syntatic sugar to create chat prompt / chat message more easily (run-llama#11583) Fix Issue 11565 - The MilvusVectorStore MetaDataFilters FilterCondition.OR is ignored (run-llama#11566) docs: fixes LangfuseCallbackHandler link (run-llama#11576) GHA: Add Check for repo source (run-llama#11575) add raptor (run-llama#11527) Logan/v0.10.15 (run-llama#11551) feat: adds langfuse callback handler (run-llama#11324) fixed storage context update & service context issue (run-llama#11475) Add async capability to OpensearchVectorStore (run-llama#11513) Logan/fix publish (run-llama#11549) Prevent async_response_gen from Stalling with asyncio Timeout (run-llama#11548) VideoDB Integration for Retrievers (run-llama#11463) fix import error in CLI (run-llama#11544) Updated the simple fusion to handle duplicate nodes (run-llama#11542) Add mixedbread reranker cookbook (run-llama#11536) Fixed some minor gramatical issues (run-llama#11530) ...
Izukimat
pushed a commit
to Izukimat/llama_index
that referenced
this pull request
Mar 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #11474
Type of Change
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration