Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make SupabaseVectorStore a subclass of BasePydanticVectorStore #11476

Merged

Conversation

dan-tee
Copy link
Contributor

@dan-tee dan-tee commented Feb 28, 2024

Description

This bug was also present for SupabaseVectorStore, so it could not be used in a IngestionPipeline: #10688

This PR fixes the bug above by making SupabaseVectorStore a subclass of BasePydanticVectorStore.

This change is analogous to
https://github.com/run-llama/llama_index/pull/11435/files#diff-a903926a12a2a95032e32938ee7a8d5ab960dda9872690435e6f53a527f6368cR98

Fixes # (issue)

Type of Change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Added new unit/integration tests
  • Added new notebook (that tests end-to-end)
  • I stared at the code and made sure it makes sense

Suggested Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added Google Colab support for the newly added notebooks.
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I ran make format; make lint to appease the lint gods

This bug was also present for SupabaseVectorStore, so it could not be used in a IngestionPipeline: run-llama#10688

This PR fixes the bug above by making SupabaseVectorStore a subclass of BasePydanticVectorStore.

This change is analogous to
https://github.com/run-llama/llama_index/pull/11435/files#diff-a903926a12a2a95032e32938ee7a8d5ab960dda9872690435e6f53a527f6368cR98
@dosubot dosubot bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Feb 28, 2024
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Feb 28, 2024
@logan-markewich logan-markewich merged commit a0d52ac into run-llama:main Feb 28, 2024
8 checks passed
Dominastorm pushed a commit to uptrain-ai/llama_index that referenced this pull request Feb 28, 2024
anoopshrma pushed a commit to anoopshrma/llama_index that referenced this pull request Mar 2, 2024
Izukimat pushed a commit to Izukimat/llama_index that referenced this pull request Mar 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm This PR has been approved by a maintainer size:S This PR changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants