llama-index-embeddings-vertex #11528
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
the
size:L
ravi03071991
reviewed
Mar 1, 2024
| def _get_text_embeddings(self, texts: List[str]) -> List[List[float]]: | ||
| """Get text embeddings.""" | ||
| embeddings_list: List[List[float]] = [] | ||
| for text in texts: |
There was a problem hiding this comment.
this is a sequential operation, is there no batch operation available here?
| """Get text embedding.""" | ||
| return self.get_general_text_embedding(text) | ||
|
|
||
| async def _aget_text_embedding(self, text: str) -> List[float]: |
There was a problem hiding this comment.
vertexai don't have async client to get embeddings?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adding support for vertex ai embeddings
Fixes # (issue)
Type of Change
Please delete options that are not relevant.
How Has This Been Tested?
tested locally that vertex embeddings actually work.
Added simplest test
Checklist:
make format; make lintto appease the lint gods