Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed some minor gramatical issues #11530

Merged
merged 7 commits into from
Mar 1, 2024
Merged

Fixed some minor gramatical issues #11530

merged 7 commits into from
Mar 1, 2024

Conversation

ShorthillsAI
Copy link
Contributor

@ShorthillsAI ShorthillsAI commented Mar 1, 2024 •
edited
Loading

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes # (issue)

Type of Change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Added new unit/integration tests
  • Added new notebook (that tests end-to-end)
  • I stared at the code and made sure it makes sense

Suggested Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added Google Colab support for the newly added notebooks.
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I ran make format; make lint to appease the lint gods

@dosubot dosubot bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Mar 1, 2024
@review-notebook-app Review Notebook App
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

ravi03071991
ravi03071991 approved these changes Mar 1, 2024
View reviewed changes
Copy link
Contributor

@ravi03071991 ravi03071991 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Mar 1, 2024
@ravi03071991 ravi03071991 merged commit 53e9f52 into run-llama:main Mar 1, 2024
9 checks passed
anoopshrma pushed a commit to anoopshrma/llama_index that referenced this pull request Mar 2, 2024
@ShorthillsAI @anoopshrma
Fixed some minor gramatical issues (run-llama#11530)
407d8f7 
* Fixed some gramatical mistakes (run-llama#82)

* Update discover_llamaindex.md

* Update installation.md

* Update reading.md

* Update starter_example.md

* Update starter_example_local.md

* Update v0_10_0_migration.md

* Update 2024-02-28-rag-bootcamp-vector-institute.ipynb

* Update multimodal.md

* Update chatbots.md
bdonkey added a commit to bdonkey/gpt_index that referenced this pull request Mar 5, 2024
@bdonkey
Merge branch 'main' into ssdev
d97c757 
* main: (2881 commits)
  Feature: Improve batch embedding generation throughput for Cohere in Bedrock (run-llama#11572)
  tqdm: add tdqm.gather (run-llama#11562)
  Fix URLs in Prompts documentation (run-llama#11571)
  Corrected colab links (run-llama#11577)
  add syntatic sugar to create chat prompt / chat message more easily  (run-llama#11583)
  Fix Issue 11565 - The MilvusVectorStore MetaDataFilters FilterCondition.OR is ignored (run-llama#11566)
  docs: fixes LangfuseCallbackHandler link (run-llama#11576)
  GHA: Add Check for repo source (run-llama#11575)
  add raptor (run-llama#11527)
  Logan/v0.10.15 (run-llama#11551)
  feat: adds langfuse callback handler (run-llama#11324)
  fixed storage context update & service context issue (run-llama#11475)
  Add async capability to OpensearchVectorStore (run-llama#11513)
  Logan/fix publish (run-llama#11549)
  Prevent async_response_gen from Stalling with asyncio Timeout (run-llama#11548)
  VideoDB Integration for Retrievers (run-llama#11463)
  fix import error in CLI (run-llama#11544)
  Updated the simple fusion to handle duplicate nodes (run-llama#11542)
  Add mixedbread reranker cookbook (run-llama#11536)
  Fixed some minor gramatical issues (run-llama#11530)
  ...
Izukimat pushed a commit to Izukimat/llama_index that referenced this pull request Mar 29, 2024
@ShorthillsAI
Fixed some minor gramatical issues (run-llama#11530)
874da1b 
* Fixed some gramatical mistakes (run-llama#82)

* Update discover_llamaindex.md

* Update installation.md

* Update reading.md

* Update starter_example.md

* Update starter_example_local.md

* Update v0_10_0_migration.md

* Update 2024-02-28-rag-bootcamp-vector-institute.ipynb

* Update multimodal.md

* Update chatbots.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ravi03071991 ravi03071991 ravi03071991 approved these changes

Assignees
No one assigned
Labels
lgtm This PR has been approved by a maintainer size:S This PR changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ShorthillsAI @ravi03071991