-
Notifications
You must be signed in to change notification settings - Fork 5.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Put py.typed in all necessary folders #12351
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
the
size:S
This PR changes 10-29 lines, ignoring generated files.
label
Mar 28, 2024
dosubot
bot
added
size:M
This PR changes 30-99 lines, ignoring generated files.
and removed
size:S
This PR changes 10-29 lines, ignoring generated files.
labels
Mar 28, 2024
This is the tree diff for review Generated this via: git diff-tree -r main feature/py_typed --name-only > diff_files.txt
temp_dir=$(mktemp -d)
# Read each line from the file list
while IFS= read -r file; do
mkdir -p "$temp_dir/$(dirname "$file")" # Create the directory structure
touch "$temp_dir/$file" # Create an empty file to represent the file
done < diff_files.txt
# Now, you can use `tree` to display the structure
tree "$temp_dir" > tree.txt
|
This might not be the best solution. Just a suggestion. |
A couple other ideas:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This creates a script which can both create and check the existence of py.typed in all folders
Even if a package is not "typed" per-se. This allows for at least some mypy usage. Here are a few examples:
Run these commands:
poetry self update # Get ^1.8.2 poetry install poetry run mypy mypy.py
You will get:
Fixes #12345
WOW! that's a cool issue number
Version Bump?
Did I bump the version in the
pyproject.toml
file of the package I am updating? (Except for thellama-index-core
package)Type of Change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Suggested Checklist:
make format; make lint
to appease the lint gods