Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add stateful and loop components #14235

Merged
merged 6 commits into from
Jun 30, 2024
Merged

Add stateful and loop components #14235

merged 6 commits into from
Jun 30, 2024

Conversation

jerryjliu
Copy link
Collaborator

@jerryjliu jerryjliu commented Jun 19, 2024 •
edited
Loading

  • created a StatefulFnComponent - a component that also stores state
  • you can specify state at the level of a query pipeline, and it will propagate to every StatefulFnComponent
  • you do NOT need to explicitly define links / keys for the state variable, it is autoinjected by a StatefulFnComponent
  • created a LoopComponent that can loop around a query pipeline (whether its stateful or not, doesn't matter, that is not exposed to the LoopComponent)

@review-notebook-app Review Notebook App
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

@jerryjliu jerryjliu changed the title [draft, don't merge] add stateful and loop components [WIP] add stateful and loop components Jun 19, 2024
@jerryjliu jerryjliu marked this pull request as ready for review June 30, 2024 00:27
@dosubot dosubot bot added the size:XL This PR changes 500-999 lines, ignoring generated files. label Jun 30, 2024
@jerryjliu jerryjliu changed the title [WIP] add stateful and loop components Add stateful and loop components Jun 30, 2024
@jerryjliu jerryjliu merged commit ff74654 into main Jun 30, 2024
8 checks passed
@jerryjliu jerryjliu deleted the jerry/add_loop_component branch June 30, 2024 00:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
size:XL This PR changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@jerryjliu