Update LlamaCloud integration #14254
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
the
size:XL
| f"pipelines/execution?id={pipeline_execution.id}" | ||
| ) | ||
|
|
||
| return pipeline_execution.id |
There was a problem hiding this comment.
Ah, so nice to remove this actually haha
| @@ -62,6 +86,110 @@ def __init__( | |||
| self._service_context = None | |||
| self._callback_manager = callback_manager or Settings.callback_manager | |||
|
|
|||
| def _wait_for_pipeline_ingestion( | |||
There was a problem hiding this comment.
Note to self: At some point, this probably needs to be async
| **kwargs: Any, | ||
| ) -> "LlamaCloudIndex": | ||
| """Build a Vectara index from a sequence of documents.""" | ||
| """Build a LlamaCloud managed index from a sequence of documents.""" |
logan-markewich
approved these changes
Jun 21, 2024
sourabhdesai
approved these changes
Jun 21, 2024
| return [ | ||
| SentenceSplitter(), | ||
| OpenAIEmbedding(), | ||
| ] | ||
|
|
||
|
|
||
| def get_client( | ||
| api_key: Optional[str] = None, | ||
| base_url: Optional[str] = None, | ||
| app_url: Optional[str] = None, |
There was a problem hiding this comment.
what's app_url for? seems like its not being used?
There was a problem hiding this comment.
previously, this was used to print link to go to the webapp.
|
Besides some nits, I think this is good to merge. Don't want to hold up anything, so going to merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updates LlamaCloud integration
Version Bump?
Did I bump the version in the
pyproject.tomlfile of the package I am updating? (Except for thellama-index-corepackage)Type of Change
How Has This Been Tested?