fix dropped tokens in ReActAgentWorker._arun_step_stream #14308
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
the
size:XS
Tshimanga
changed the title
| ) | ||
| is_done = False | ||
| async for latest_chunk in chat_stream: | ||
| full_response = latest_chunk | ||
| is_done = self._infer_stream_chunk_is_final(latest_chunk) | ||
| if is_done: | ||
| full_response.delta = full_response.message.content |
There was a problem hiding this comment.
I'm kind of confused what's happening here
The delta should only have the newest tokens from the stream, not the entire response?
I haven't noticed issues with the react agent dropping tokens, can you give some example that shows the issue?
There was a problem hiding this comment.
tl;dr there was a bit of nuance I missed in debugging the issue. Responded here with more detail/context
#14307 (comment)
|
Closing in favour of #14587 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The
ReActAgentWorker._arun_step_streammethod drops any tokens generated before the is_done condition triggers.Fixes #14307
New Package?
Did I fill in the
tool.llamahubsection in thepyproject.tomland provide a detailed README.md for my new integration or package?Version Bump?
Did I bump the version in the
pyproject.tomlfile of the package I am updating? (Except for thellama-index-corepackage)Type of Change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Suggested Checklist:
make format; make lintto appease the lint gods