Added utility for saving results to specified folder #14375
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
the
size:XS
nerdai
reviewed
Jun 25, 2024
llama-index-packs/llama-index-packs-rag-evaluator/llama_index/packs/rag_evaluator/base.py
Outdated
Show resolved
Hide resolved
dosubot
bot
added
size:S
nerdai
reviewed
Jun 26, 2024
| @@ -44,6 +46,7 @@ def __init__( | |||
| judge_llm: Optional[LLM] = None, | |||
| embed_model: Optional[BaseEmbedding] = None, | |||
| show_progress: bool = True, | |||
| result_path = None, | |||
There was a problem hiding this comment.
missing type: Should be Optional[str]?
There was a problem hiding this comment.
Good point, thx for fixing @logan-markewich
logan-markewich
approved these changes
Jun 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adding utility to specify path to save
_evaluations.jsonandbenchmark.csvFixes # (issue)
New Package?
Did I fill in the
tool.llamahubsection in thepyproject.tomland provide a detailed README.md for my new integration or package?Version Bump?
Did I bump the version in the
pyproject.tomlfile of the package I am updating? (Except for thellama-index-corepackage)Type of Change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Suggested Checklist:
make format; make lintto appease the lint gods