Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UnstructuredReader enhancements. #14390

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Falven
Copy link
Contributor

@Falven Falven commented Jun 25, 2024

Description

Several enhancements to the UnstructuredReader.

  • Allow kwargs to unstructured so you can use any of the features of the lib.
  • Generation of deterministic ids using element.id_to_hash as an option for document lifecyle management
  • Option to exclude any of the metadata keys from final result
  • Use native element.metadata.to_dict() transformation rather than hard-coded metadata serialization
  • Cleaned up constructor a bit and added from_api helper.

New Package?

Version Bump?

Did I bump the version in the pyproject.toml file of the package I am updating? (Except for the llama-index-core package)

  • Yes
  • No (Not sure where)

Type of Change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • I stared at the code and made sure it makes sense
  • I ran the code on my own project

Suggested Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I ran make format; make lint to appease the lint gods

@dosubot dosubot bot added the size:L This PR changes 100-499 lines, ignoring generated files. label Jun 25, 2024
@Falven Falven changed the title Unstructured file reader enhancements. UnstructuredReader enhancements. Jun 25, 2024
Copy link
Collaborator

@anoopshrma anoopshrma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You'll have to bump the version also for this to reflect in pypi. You can do that by upgrading the version mentioned here:

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jun 26, 2024
@Falven Falven force-pushed the feature/unstructured_file_reader_enhancements branch 2 times, most recently from ab1bdc6 to f8616f7 Compare July 1, 2024 15:59
@Falven Falven force-pushed the feature/unstructured_file_reader_enhancements branch from f8616f7 to a15154a Compare July 4, 2024 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm This PR has been approved by a maintainer size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants