Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add async methods to azure ai search #14496

Conversation

EmanuelCampos
Copy link
Contributor

No description provided.

@dosubot dosubot bot added the size:L This PR changes 100-499 lines, ignoring generated files. label Jul 1, 2024
Copy link
Collaborator

@logan-markewich logan-markewich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems fine to me, but shouldn't we also add aquery?

@EmanuelCampos
Copy link
Contributor Author

This seems fine to me, but shouldn't we also add aquery?

ops forgot it, added!

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jul 3, 2024
@logan-markewich logan-markewich enabled auto-merge (squash) July 3, 2024 17:09
@logan-markewich logan-markewich merged commit 7a3b90b into run-llama:main Jul 3, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm This PR has been approved by a maintainer size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants