Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add explanation to OptimizerDemo.ipynb #14615

Merged
merged 2 commits into from
Jul 7, 2024

Conversation

sad-mathematician
Copy link
Contributor

Added an explanation at the beginning of the notebook describing what the Sentence Embedding Optimizer does.

Added an explanation at the beginning of the notebook describing what the Sentence Embedding Optimizer does.
@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Jul 7, 2024
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

Copy link
Contributor

@nerdai nerdai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @sad-mathematician for this explanation.

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jul 7, 2024
@nerdai nerdai enabled auto-merge (squash) July 7, 2024 18:53
@nerdai nerdai merged commit efad77e into run-llama:main Jul 7, 2024
8 checks passed
@sad-mathematician sad-mathematician deleted the patch-3 branch July 8, 2024 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm This PR has been approved by a maintainer size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants