-
Notifications
You must be signed in to change notification settings - Fork 5.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upstash Storage Chat Store Integration #16237
Merged
logan-markewich
merged 18 commits into
run-llama:main
from
fahreddinozcan:upstash-chat-store-integration
Sep 30, 2024
Merged
Upstash Storage Chat Store Integration #16237
logan-markewich
merged 18 commits into
run-llama:main
from
fahreddinozcan:upstash-chat-store-integration
Sep 30, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
the
size:L
This PR changes 100-499 lines, ignoring generated files.
label
Sep 26, 2024
…ahreddinozcan/llama_index into upstash-chat-store-integration
You'll need to mark the tests as skip if they rely on API keys being present. Either that, or you'll have to mock out the API calls |
…ahreddinozcan/llama_index into upstash-chat-store-integration
@logan-markewich The problem is now solved. Thanks for the heads up. |
..._store/llama-index-storage-chat-store-upstash/llama_index/storage/chat_store/upstash/base.py
Outdated
Show resolved
Hide resolved
..._store/llama-index-storage-chat-store-upstash/llama_index/storage/chat_store/upstash/base.py
Show resolved
Hide resolved
dosubot
bot
added
size:XL
This PR changes 500-999 lines, ignoring generated files.
and removed
size:L
This PR changes 100-499 lines, ignoring generated files.
labels
Sep 30, 2024
…e-chat-store-upstash/llama_index/storage/chat_store/upstash/base.py
logan-markewich
approved these changes
Sep 30, 2024
raspawar
pushed a commit
to raspawar/llama_index
that referenced
this pull request
Oct 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Fixes # (issue)
New Package?
Did I fill in the
tool.llamahub
section in thepyproject.toml
and provide a detailed README.md for my new integration or package?Version Bump?
Did I bump the version in the
pyproject.toml
file of the package I am updating? (Except for thellama-index-core
package)Type of Change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Suggested Checklist:
make format; make lint
to appease the lint gods