Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rm extra print statements & replace create tmpfile function #16291

Merged
merged 2 commits into from
Sep 30, 2024

Conversation

nightosong
Copy link
Contributor

Description

  1. _get_candidate_names function is an internal implementation detail of the tempfile module and mkstemp is a better choice.
  2. in the branch where key is empty, there are unnecessary and redundant print statements that need to be removed.

Fixes # (issue)

Version Bump?

Did I bump the version in the pyproject.toml file of the package I am updating? (Except for the llama-index-core package)

  • Yes

Type of Change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • I stared at the code and made sure it makes sense

Suggested Checklist:

  • I have performed a self-review of my own code
  • My changes generate no new warnings
  • New and existing unit tests pass locally with my changes

@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Sep 30, 2024
@nightosong nightosong changed the title rm useless print & replace create tmpfile api rm extra print statements & replace create tmpfile function Sep 30, 2024
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Sep 30, 2024
@logan-markewich logan-markewich merged commit a620a26 into run-llama:main Sep 30, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm This PR has been approved by a maintainer size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants