Add Airtrain + Llama Index cookbook #16332
Merged
+498
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
the
size:XL
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
nerdai
reviewed
Oct 2, 2024
| @@ -0,0 +1,507 @@ | |||
| { | |||
There was a problem hiding this comment.
Can you kindly do a string search and replace in this notebook to change "Llama Index" (with space) to "LlamaIndex" (without space).
Reply via ReviewNB
| @@ -0,0 +1,507 @@ | |||
| { | |||
There was a problem hiding this comment.
Line #18. if not isinstance(ev, CompletedDocumentRetrievalEvent):
It's actually not necessary to check the type of event. Under the hood, inspection is being done on the step's to determine its accepted events.
Reply via ReviewNB
| @@ -0,0 +1,507 @@ | |||
| { | |||
There was a problem hiding this comment.
Line #22. return AirtrainDocumentDatasetEvent(metadata=dataset_meta)
you can probably just return StopEvent(result=metadata) here and omit the complete_workflow step.
Reply via ReviewNB
dosubot
bot
added
size:L
|
Thanks for the review @nerdai ; I applied your suggested changes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a cookbook which describes how to use Airtrain with Llama Index. It introduces no new dependencies for any Llama Index packages, but the notebook for the cookbook depends on the Airtrain python package.
Version Bump?
Did I bump the version in the
pyproject.tomlfile of the package I am updating? (Except for thellama-index-corepackage)Type of Change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
(^ notebook requires user-specific API keys, but otherwise can be executed as-is end-to-end)
Suggested Checklist:
(^ in the sense that the notebook itself is a test)
make format; make lintto appease the lint gods