Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suppress token detaching exception during workflow tracing #16364

Merged

Conversation

B-Step62
Copy link
Contributor

@B-Step62 B-Step62 commented Oct 4, 2024

Description

Follow up for #16290 (comment). The exception for the token detaching is still surfaced when using MLflow Tracing. The fundamental fix is still TBD, but this PR just suppress it to resolve the customer-facing issue right now.

Fwiw this error message is non blocking anyway - but surfacing it would confuse users while it is not their fault.

Screenshot 2024-10-04 at 9 52 00

New Package?

Did I fill in the tool.llamahub section in the pyproject.toml and provide a detailed README.md for my new integration or package?

  • Yes
  • No

Version Bump?

Did I bump the version in the pyproject.toml file of the package I am updating? (Except for the llama-index-core package)

  • Yes
  • No

Type of Change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Added new unit/integration tests
  • Added new notebook (that tests end-to-end)
  • I stared at the code and made sure it makes sense

Also tested the change in notebook:

Screenshot 2024-10-04 at 9 34 02

Suggested Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added Google Colab support for the newly added notebooks.
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I ran make format; make lint to appease the lint gods

@dosubot dosubot bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Oct 4, 2024
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Oct 4, 2024
@logan-markewich logan-markewich enabled auto-merge (squash) October 4, 2024 01:16
@logan-markewich logan-markewich merged commit 03d7540 into run-llama:main Oct 4, 2024
8 of 10 checks passed
@B-Step62 B-Step62 deleted the suppress-context-exception branch October 4, 2024 01:53
raspawar pushed a commit to raspawar/llama_index that referenced this pull request Oct 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm This PR has been approved by a maintainer size:S This PR changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants