Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JSON path prompt debug facilitation #9097

Merged
merged 8 commits into from
Feb 28, 2024

Conversation

dylan1218
Copy link
Contributor

@dylan1218 dylan1218 commented Nov 22, 2023

Description

Update the JSON path base prompt to include an identifier that can be parsed from json_query.py. A parsing function was added to json_query.py to more accurately return the JSON path query string, and if not found an error clearly explaining the issues is returned to the user.

Fixes # #7587

Type of Change

[x] New feature (non-breaking change which adds functionality)
(1) Updates the default JSON path prompt to include an identifier that can be parsed with regex
(2) Adds a regex parsing function that finds the JSONPath prompt. If not found provides clearer error handling for trouble shooting

How Has This Been Tested?

[x] I stared at the code and made sure it makes sense
[x] Tested by initializing a JSONQueryEngine initialized with an Azure openAI LLM service context and making various queries to ensure that JSON path was being parsed correctlly from the LLM response.

Suggested Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added Google Colab support for the newly added notebooks.
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I ran make format; make lint to appease the lint gods

@dosubot dosubot bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Nov 22, 2023
@logan-markewich
Copy link
Collaborator

@dylan1218 Looks like this change breaks some unit tests -- can you fix those up?

Also, run make lint to fix the linting CI

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Feb 28, 2024
@dosubot dosubot bot added size:XS This PR changes 0-9 lines, ignoring generated files. and removed size:S This PR changes 10-29 lines, ignoring generated files. labels Feb 28, 2024
@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. and removed size:XS This PR changes 0-9 lines, ignoring generated files. labels Feb 28, 2024
@logan-markewich logan-markewich merged commit 153836f into run-llama:main Feb 28, 2024
4 of 7 checks passed
Dominastorm pushed a commit to uptrain-ai/llama_index that referenced this pull request Feb 28, 2024
anoopshrma pushed a commit to anoopshrma/llama_index that referenced this pull request Mar 2, 2024
Izukimat pushed a commit to Izukimat/llama_index that referenced this pull request Mar 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm This PR has been approved by a maintainer size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants