-
Notifications
You must be signed in to change notification settings - Fork 5.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JSON path prompt debug facilitation #9097
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
update DEFAULT_JSON_PATH_TMPL to facilitate debugging
… prompt response template
dosubot
bot
added
the
size:S
This PR changes 10-29 lines, ignoring generated files.
label
Nov 22, 2023
@dylan1218 Looks like this change breaks some unit tests -- can you fix those up? Also, run |
logan-markewich
approved these changes
Feb 28, 2024
dosubot
bot
added
size:XS
This PR changes 0-9 lines, ignoring generated files.
and removed
size:S
This PR changes 10-29 lines, ignoring generated files.
labels
Feb 28, 2024
dosubot
bot
added
size:M
This PR changes 30-99 lines, ignoring generated files.
and removed
size:XS
This PR changes 0-9 lines, ignoring generated files.
labels
Feb 28, 2024
Dominastorm
pushed a commit
to uptrain-ai/llama_index
that referenced
this pull request
Feb 28, 2024
anoopshrma
pushed a commit
to anoopshrma/llama_index
that referenced
this pull request
Mar 2, 2024
Izukimat
pushed a commit
to Izukimat/llama_index
that referenced
this pull request
Mar 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Update the JSON path base prompt to include an identifier that can be parsed from json_query.py. A parsing function was added to json_query.py to more accurately return the JSON path query string, and if not found an error clearly explaining the issues is returned to the user.
Fixes # #7587
Type of Change
[x] New feature (non-breaking change which adds functionality)
(1) Updates the default JSON path prompt to include an identifier that can be parsed with regex
(2) Adds a regex parsing function that finds the JSONPath prompt. If not found provides clearer error handling for trouble shooting
How Has This Been Tested?
[x] I stared at the code and made sure it makes sense
[x] Tested by initializing a JSONQueryEngine initialized with an Azure openAI LLM service context and making various queries to ensure that JSON path was being parsed correctlly from the LLM response.
Suggested Checklist:
make format; make lint
to appease the lint gods