Issue 9748, views are working after my tests #9802
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
the
size:XS
llama_index/utilities/sql_wrapper.py
Outdated
| custom_table_info: Optional[dict] = None, | ||
| view_support: bool = False, | ||
| view_support: bool = True, |
There was a problem hiding this comment.
Is there some consequence for changing the default vs. Letting the dev make the decision?
Does this still work fine for normal tables without views?
There was a problem hiding this comment.
For me it does work with tables and views. I also tried a mix with tables and views. it's not a big change but I'd rather have someone else test this as well before me breaking the whole framework.
|
Since the option exists, I'd rather not change the defaults for now I think |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
current situation: SQLDatabase(engine, include_tables=["city_stats"])
obj_index = ObjectIndex.from_objects(table_schema_objs,table_node_mapping,VectorStoreIndex,)
query_engine = SQLTableRetrieverQueryEngine(sql_database, obj_index.as_retriever(),)
preferred new option: SQLDatabase(engine, include_databaseobjects=["city_stats","myview1","mytable1","myview2"])
Fixes # It seems views was already implemented but not enabled. After enabling I ran soms tests and it seems to work for me.
Type of Change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Suggested Checklist: